diff options
| author | Wei Fang <wei.fang@nxp.com> | 2023-07-18 17:09:27 +0800 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2023-07-19 20:59:16 -0700 |
| commit | 36bde9c1accb8f7aa908b9c04c0769251629e6fd (patch) | |
| tree | 0a949ee7cc6b8f1ce99e155e78ea653b5782d41d /drivers | |
| parent | 3b23ecd53ab5cc46965bc49dece460c0e85ddaac (diff) | |
| download | lwn-36bde9c1accb8f7aa908b9c04c0769251629e6fd.tar.gz lwn-36bde9c1accb8f7aa908b9c04c0769251629e6fd.zip | |
net: fec: remove fec_set_mac_address() from fec_enet_init()
The fec_enet_init() is only invoked when the FEC driver probes, and
the network device of FEC is not been brought up at this moment. So
the fec_set_mac_address() does nothing and just returns zero when it
is invoked in the fec_enet_init(). Actually, the MAC address is set
into the hardware through fec_restart() which is also called in the
fec_enet_init().
Signed-off-by: Wei Fang <wei.fang@nxp.com>
Link: https://lore.kernel.org/r/20230718090928.2654347-3-wei.fang@nxp.com
Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/freescale/fec_main.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index fef313d3380e..03ac7690b5c4 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3966,9 +3966,6 @@ static int fec_enet_init(struct net_device *ndev) if (ret) goto free_queue_mem; - /* make sure MAC we just acquired is programmed into the hw */ - fec_set_mac_address(ndev, NULL); - /* Set receive and transmit descriptor base. */ for (i = 0; i < fep->num_rx_queues; i++) { struct fec_enet_priv_rx_q *rxq = fep->rx_queue[i]; |