summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorManoj Kumar <manoj@linux.vnet.ibm.com>2015-10-21 15:15:30 -0500
committerJames Bottomley <JBottomley@Odin.com>2015-10-30 17:19:35 +0900
commitb22b4037a013e9ce77cec79d95fdcdc9bece0955 (patch)
treec85f1ede1c4f352b4d38101e47c041f75e9a3d84 /drivers
parent11f43ae7735a04994ef3c33295d386ef4e5529b7 (diff)
downloadlwn-b22b4037a013e9ce77cec79d95fdcdc9bece0955.tar.gz
lwn-b22b4037a013e9ce77cec79d95fdcdc9bece0955.zip
cxlflash: Fix to double the delay each time
The operator used to double the master context response delay is incorrect and does not result in delay doubling. To fix, use a left shift instead of the XOR operator. Reported-by: Tomas Henzl <thenzl@redhat.com> Signed-off-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com> Signed-off-by: Manoj N. Kumar <manoj@linux.vnet.ibm.com> Reviewed-by: Brian King <brking@linux.vnet.ibm.com> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com> Reviewed-by: Tomas Henzl <thenzl@redhat.com> Signed-off-by: James Bottomley <JBottomley@Odin.com>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/scsi/cxlflash/main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/scsi/cxlflash/main.c b/drivers/scsi/cxlflash/main.c
index c77cb929dacb..51883bef8444 100644
--- a/drivers/scsi/cxlflash/main.c
+++ b/drivers/scsi/cxlflash/main.c
@@ -303,7 +303,7 @@ write_rrin:
if (rrin != 0x1)
break;
/* Double delay each time */
- udelay(2 ^ nretry);
+ udelay(2 << nretry);
} while (nretry++ < MC_ROOM_RETRY_CNT);
}