diff options
| author | Daniel Scally <dan.scally@ideasonboard.com> | 2023-09-20 14:41:09 +0100 |
|---|---|---|
| committer | Wolfram Sang <wsa@kernel.org> | 2023-09-22 12:04:39 +0200 |
| commit | 59851fb05d759f13662be143eff0aae605815b0e (patch) | |
| tree | 81991bedf997058976c8617642ecfb56342168f2 /drivers | |
| parent | db6aee6083a56ac4a6cd1b08fff7938072bcd0a3 (diff) | |
| download | lwn-59851fb05d759f13662be143eff0aae605815b0e.tar.gz lwn-59851fb05d759f13662be143eff0aae605815b0e.zip | |
i2c: xiic: Correct return value check for xiic_reinit()
The error paths for xiic_reinit() return negative values on failure
and 0 on success - this error message therefore is triggered on
_success_ rather than failure. Correct the condition so it's only
shown on failure as intended.
Fixes: 8fa9c9388053 ("i2c: xiic: return value of xiic_reinit")
Signed-off-by: Daniel Scally <dan.scally@ideasonboard.com>
Acked-by: Michal Simek <michal.simek@amd.com>
Reviewed-by: Andi Shyti <andi.shyti@kernel.org>
Signed-off-by: Wolfram Sang <wsa@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/i2c/busses/i2c-xiic.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/busses/i2c-xiic.c b/drivers/i2c/busses/i2c-xiic.c index b3bb97762c85..71391b590ada 100644 --- a/drivers/i2c/busses/i2c-xiic.c +++ b/drivers/i2c/busses/i2c-xiic.c @@ -710,7 +710,7 @@ static irqreturn_t xiic_process(int irq, void *dev_id) * reset the IP instead of just flush fifos */ ret = xiic_reinit(i2c); - if (!ret) + if (ret < 0) dev_dbg(i2c->adap.dev.parent, "reinit failed\n"); if (i2c->rx_msg) { |