diff options
| author | Cai Huoqing <cai.huoqing@linux.dev> | 2023-09-19 10:27:15 +0800 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-09-20 10:54:45 +0100 |
| commit | 22b6e7f3d6d51ff2716480f3d8f3098d90d69165 (patch) | |
| tree | a530c8e179956c0571b3b3330af42c98d46e091f /drivers | |
| parent | 4e4b1798cc90e376b8b61d0098b4093898a32227 (diff) | |
| download | lwn-22b6e7f3d6d51ff2716480f3d8f3098d90d69165.tar.gz lwn-22b6e7f3d6d51ff2716480f3d8f3098d90d69165.zip | |
net: hinic: Fix warning-hinic_set_vlan_fliter() warn: variable dereferenced before check 'hwdev'
'hwdev' is checked too late and hwdev will not be NULL, so remove the check
Fixes: 2acf960e3be6 ("net: hinic: Add support for configuration of rx-vlan-filter by ethtool")
Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/r/202309112354.pikZCmyk-lkp@intel.com/
Signed-off-by: Cai Huoqing <cai.huoqing@linux.dev>
Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ethernet/huawei/hinic/hinic_port.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/net/ethernet/huawei/hinic/hinic_port.c b/drivers/net/ethernet/huawei/hinic/hinic_port.c index 9406237c461e..f81a43d2cdfc 100644 --- a/drivers/net/ethernet/huawei/hinic/hinic_port.c +++ b/drivers/net/ethernet/huawei/hinic/hinic_port.c @@ -456,9 +456,6 @@ int hinic_set_vlan_fliter(struct hinic_dev *nic_dev, u32 en) u16 out_size = sizeof(vlan_filter); int err; - if (!hwdev) - return -EINVAL; - vlan_filter.func_idx = HINIC_HWIF_FUNC_IDX(hwif); vlan_filter.enable = en; |