diff options
| author | Arnd Bergmann <arnd@arndb.de> | 2016-10-25 17:56:23 +0200 |
|---|---|---|
| committer | Jonathan Cameron <jic23@kernel.org> | 2016-10-25 17:25:34 +0100 |
| commit | 3089ec2c104ccfb7295d6c2a25d5b505cc59669b (patch) | |
| tree | fdc1eecb6933c5aa7e921caf9cb79c82e2d7293c /drivers | |
| parent | 3904b28efb2c780c23dcddfb87e07fe0230661e5 (diff) | |
| download | lwn-3089ec2c104ccfb7295d6c2a25d5b505cc59669b.tar.gz lwn-3089ec2c104ccfb7295d6c2a25d5b505cc59669b.zip | |
staging: iio: cdc/ad7746: fix missing return value
As found by "gcc -Wmaybe-uninitialized", the latest change to the
driver lacked an initalization for the return code in one of the
added cases:
drivers/staging/iio/cdc/ad7746.c: In function ‘ad7746_read_raw’:
drivers/staging/iio/cdc/ad7746.c:655:2: error: ‘ret’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
This sets it to IIO_VAL_INT, which I think is what we want here.
Fixes: 2296c0623eb7 ("staging: iio: cdc: ad7746: implement IIO_CHAN_INFO_SAMP_FREQ")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/iio/cdc/ad7746.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/staging/iio/cdc/ad7746.c b/drivers/staging/iio/cdc/ad7746.c index f41251ceeacd..a5828f9aa437 100644 --- a/drivers/staging/iio/cdc/ad7746.c +++ b/drivers/staging/iio/cdc/ad7746.c @@ -642,6 +642,7 @@ static int ad7746_read_raw(struct iio_dev *indio_dev, case IIO_VOLTAGE: *val = ad7746_vt_filter_rate_table[ (chip->config >> 6) & 0x3][0]; + ret = IIO_VAL_INT; break; default: ret = -EINVAL; |