diff options
| author | Eddie James <eajames@linux.ibm.com> | 2023-06-12 14:56:49 -0500 |
|---|---|---|
| committer | Joel Stanley <joel@jms.id.au> | 2023-08-09 15:43:27 +0930 |
| commit | 2f42220f350049e15df026ad87be36d967102cbf (patch) | |
| tree | a2dc5d391e691498c029089617d6fdebfd4e80e2 /drivers | |
| parent | 19c064defcce7550f9a7027384ae46fda0d27394 (diff) | |
| download | lwn-2f42220f350049e15df026ad87be36d967102cbf.tar.gz lwn-2f42220f350049e15df026ad87be36d967102cbf.zip | |
fsi: sbefifo: Remove limits on user-specified read timeout
There's no reason to limit the user here. The way the driver is
designed, extremely large transfers require extremely long timeouts.
Signed-off-by: Eddie James <eajames@linux.ibm.com>
Link: https://lore.kernel.org/r/20230612195657.245125-7-eajames@linux.ibm.com
Signed-off-by: Joel Stanley <joel@jms.id.au>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/fsi/fsi-sbefifo.c | 9 |
1 files changed, 2 insertions, 7 deletions
diff --git a/drivers/fsi/fsi-sbefifo.c b/drivers/fsi/fsi-sbefifo.c index 74e5baf32c8d..402e2d2fe5b8 100644 --- a/drivers/fsi/fsi-sbefifo.c +++ b/drivers/fsi/fsi-sbefifo.c @@ -971,17 +971,12 @@ static int sbefifo_read_timeout(struct sbefifo_user *user, void __user *argp) if (timeout == 0) { user->read_timeout_ms = SBEFIFO_TIMEOUT_START_RSP; - dev_dbg(dev, "Timeout reset to %d\n", user->read_timeout_ms); + dev_dbg(dev, "Timeout reset to %us\n", user->read_timeout_ms / 1000); return 0; } - if (timeout < 10 || timeout > 120) - return -EINVAL; - user->read_timeout_ms = timeout * 1000; /* user timeout is in sec */ - - dev_dbg(dev, "Timeout set to %d\n", user->read_timeout_ms); - + dev_dbg(dev, "Timeout set to %us\n", timeout); return 0; } |