diff options
| author | Ben Nizette <bn@niasdigital.com> | 2009-04-16 15:55:21 +1000 |
|---|---|---|
| committer | Pierre Ossman <pierre@ossman.eu> | 2009-06-03 21:50:23 +0200 |
| commit | e749c6f21fd7dc618f61dd178b4ee739c3cb1c31 (patch) | |
| tree | ea1fd00457fa364b85204d6d74cf7463419b28bc /drivers | |
| parent | 992697e9b342115dcf052ffa41d418cb4fe1a841 (diff) | |
| download | lwn-e749c6f21fd7dc618f61dd178b4ee739c3cb1c31.tar.gz lwn-e749c6f21fd7dc618f61dd178b4ee739c3cb1c31.zip | |
mmc/omap: Use disable_irq_nosync() from within irq handlers.
disable_irq() should wait for all running handlers to complete
before returning. As such, if it's used to disable an interrupt
from that interrupt's handler it will deadlock. This replaces
the dangerous instances with the _nosync() variant which doesn't
have this problem.
Signed-off-by: Ben Nizette <bn@niasdigital.com>
Acked-by: Tony Lindgren <tony@atomide.com>
Signed-off-by: Pierre Ossman <pierre@ossman.eu>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mmc/host/omap.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mmc/host/omap.c b/drivers/mmc/host/omap.c index bfa25c01c872..dceb5ee3bda0 100644 --- a/drivers/mmc/host/omap.c +++ b/drivers/mmc/host/omap.c @@ -822,7 +822,7 @@ static irqreturn_t mmc_omap_irq(int irq, void *dev_id) del_timer(&host->cmd_abort_timer); host->abort = 1; OMAP_MMC_WRITE(host, IE, 0); - disable_irq(host->irq); + disable_irq_nosync(host->irq); schedule_work(&host->cmd_abort_work); return IRQ_HANDLED; } |