diff options
| author | John Garry <john.garry@huawei.com> | 2020-12-21 22:30:55 +0800 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2020-12-22 08:06:38 +0000 |
| commit | e1dc20995cb9fa04b46e8f37113a7203c906d2bf (patch) | |
| tree | 2be1bf3f1fb937a524f545d0fa7f07815634f125 /drivers | |
| parent | d7f39c40ebb6986e7371510d1c20a4efee4a7f0d (diff) | |
| download | lwn-e1dc20995cb9fa04b46e8f37113a7203c906d2bf.tar.gz lwn-e1dc20995cb9fa04b46e8f37113a7203c906d2bf.zip | |
driver core: platform: Add extra error check in devm_platform_get_irqs_affinity()
The current check of nvec < minvec for nvec returned from
platform_irq_count() will not detect a negative error code in nvec.
This is because minvec is unsigned, and, as such, nvec is promoted to
unsigned in that check, which will make it a huge number (if it contained
-EPROBE_DEFER).
In practice, an error should not occur in nvec for the only in-tree
user, but add a check anyway.
Fixes: e15f2fa959f2 ("driver core: platform: Add devm_platform_get_irqs_affinity()")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/1608561055-231244-1-git-send-email-john.garry@huawei.com
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/base/platform.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/base/platform.c b/drivers/base/platform.c index ea8add164b89..74c97b65048c 100644 --- a/drivers/base/platform.c +++ b/drivers/base/platform.c @@ -351,6 +351,8 @@ int devm_platform_get_irqs_affinity(struct platform_device *dev, return -ERANGE; nvec = platform_irq_count(dev); + if (nvec < 0) + return nvec; if (nvec < minvec) return -ENOSPC; |