diff options
| author | Alex Elder <elder@linaro.org> | 2021-02-01 17:26:08 -0600 |
|---|---|---|
| committer | Jakub Kicinski <kuba@kernel.org> | 2021-02-02 08:48:15 -0800 |
| commit | c13899f187285eaa5bfc30f8692888ba2e7765cb (patch) | |
| tree | c90247463bb77f7054720850e6526887f6fcae91 /drivers | |
| parent | 088f8a2396d813e7ee49272a1a59b55139c81e64 (diff) | |
| download | lwn-c13899f187285eaa5bfc30f8692888ba2e7765cb.tar.gz lwn-c13899f187285eaa5bfc30f8692888ba2e7765cb.zip | |
net: ipa: use the right accessor in ipa_endpoint_status_skip()
When extracting the destination endpoint ID from the status in
ipa_endpoint_status_skip(), u32_get_bits() is used. This happens to
work, but it's wrong: the structure field is only 8 bits wide
instead of 32.
Fix this by using u8_get_bits() to get the destination endpoint ID.
Signed-off-by: Alex Elder <elder@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ipa/ipa_endpoint.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ipa/ipa_endpoint.c b/drivers/net/ipa/ipa_endpoint.c index 448d89da1e45..612afece303f 100644 --- a/drivers/net/ipa/ipa_endpoint.c +++ b/drivers/net/ipa/ipa_endpoint.c @@ -1164,8 +1164,8 @@ static bool ipa_endpoint_status_skip(struct ipa_endpoint *endpoint, return true; if (!status->pkt_len) return true; - endpoint_id = u32_get_bits(status->endp_dst_idx, - IPA_STATUS_DST_IDX_FMASK); + endpoint_id = u8_get_bits(status->endp_dst_idx, + IPA_STATUS_DST_IDX_FMASK); if (endpoint_id != endpoint->endpoint_id) return true; |