diff options
| author | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-09-03 15:10:38 +0200 |
|---|---|---|
| committer | Mauro Carvalho Chehab <mchehab+huawei@kernel.org> | 2020-09-07 16:03:34 +0200 |
| commit | 8fae9dd6a1e385adc041fae236e62aaeb3ae38ca (patch) | |
| tree | 4e9b64c2cb6efa2f69152e36eccb26ad8a2e2010 /drivers | |
| parent | a80abc94dff78952c7989d42ea2b71825718957f (diff) | |
| download | lwn-8fae9dd6a1e385adc041fae236e62aaeb3ae38ca.tar.gz lwn-8fae9dd6a1e385adc041fae236e62aaeb3ae38ca.zip | |
media: atomisp: print a warning if error while setting downscaler
As warned by gcc:
drivers/staging/media/atomisp//pci/isp/kernels/dvs/dvs_1.0/ia_css_dvs.host.c:237:31: warning: variable ‘isp_data_ptr’ set but not used [-Wunused-but-set-variable]
ia_css_vf_configure() logic has an error var that detects troubles
when setting the kernel for downscaling. The driver just ignores
it, without producing any warning. Add at least a warning message
on such cases.
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c index 3b850bb2d39d..dd3670972936 100644 --- a/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c +++ b/drivers/staging/media/atomisp/pci/isp/kernels/vf/vf_1.0/ia_css_vf.host.c @@ -13,6 +13,8 @@ * more details. */ +#include "atomisp_internal.h" + #include "ia_css_vf.host.h" #include <assert_support.h> #include <ia_css_err.h> @@ -129,6 +131,9 @@ ia_css_vf_configure( const struct ia_css_binary_info *info = &binary->info->sp; err = configure_kernel(info, out_info, vf_info, downscale_log2, &config); + if (err) + dev_warn(atomisp_dev, "Couldn't setup downscale\n"); + configure_dma(&config, vf_info); if (vf_info) |