diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-12-17 15:27:07 +0300 |
|---|---|---|
| committer | Alex Williamson <alex.williamson@redhat.com> | 2015-12-21 15:28:11 -0700 |
| commit | 967628827f404b3063016c138ccc7b06c54350f8 (patch) | |
| tree | 40c485cbdddac85ccec57a2c0dfb7944317eae5c /drivers | |
| parent | 4ef7675344d687a0ef5b0d7c0cee12da005870c0 (diff) | |
| download | lwn-967628827f404b3063016c138ccc7b06c54350f8.tar.gz lwn-967628827f404b3063016c138ccc7b06c54350f8.zip | |
VFIO: platform: reset: fix a warning message condition
This loop ends with count set to -1 and not zero so the warning message
isn't printed when it should be. I've fixed this by change the postop
to a preop.
Fixes: 0990822c9866 ('VFIO: platform: reset: AMD xgbe reset module')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Eric Auger <eric.auger@linaro.org>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/vfio/platform/reset/vfio_platform_amdxgbe.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c index da5356f48d0b..d4030d0c38e9 100644 --- a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c +++ b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c @@ -110,7 +110,7 @@ int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev) usleep_range(10, 15); count = 2000; - while (count-- && (ioread32(xgmac_regs->ioaddr + DMA_MR) & 1)) + while (--count && (ioread32(xgmac_regs->ioaddr + DMA_MR) & 1)) usleep_range(500, 600); if (!count) |