diff options
| author | Luis de Bethencourt <luisbg@osg.samsung.com> | 2016-06-22 20:43:30 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-07-27 09:47:36 -0700 |
| commit | 601818bdd4b0cef2e578030b09fb9ad632a4c7b6 (patch) | |
| tree | 8ace45f5a515750e1688f9c52bc64069f967304f /drivers | |
| parent | 784108d9df5aea1d58d2a56900efaa8149507964 (diff) | |
| download | lwn-601818bdd4b0cef2e578030b09fb9ad632a4c7b6.tar.gz lwn-601818bdd4b0cef2e578030b09fb9ad632a4c7b6.zip | |
staging: iio: accel: fix error check
commit ef3149eb3ddb7f9125e11c90f8330e371b55cffd upstream.
sca3000_read_ctrl_reg() returns a negative number on failure, check for
this instead of zero.
Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/staging/iio/accel/sca3000_core.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c index 02e930c55570..e4839ee4ca61 100644 --- a/drivers/staging/iio/accel/sca3000_core.c +++ b/drivers/staging/iio/accel/sca3000_core.c @@ -595,7 +595,7 @@ static ssize_t sca3000_read_frequency(struct device *dev, goto error_ret_mut; ret = sca3000_read_ctrl_reg(st, SCA3000_REG_CTRL_SEL_OUT_CTRL); mutex_unlock(&st->lock); - if (ret) + if (ret < 0) goto error_ret; val = ret; if (base_freq > 0) |