diff options
| author | Lukasz Gemborowski <lukasz.gemborowski@nokia.com> | 2016-06-27 12:57:47 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2016-08-10 11:49:29 +0200 |
| commit | 1b0b5ca8f498a29c8646a3fd3bd5accbb8f8a156 (patch) | |
| tree | 579e39685d5875a997ca021ccfc82a966188d3f7 /drivers | |
| parent | 470f47fcf2a5f9c22081c1c4708e6948e3c2dc13 (diff) | |
| download | lwn-1b0b5ca8f498a29c8646a3fd3bd5accbb8f8a156.tar.gz lwn-1b0b5ca8f498a29c8646a3fd3bd5accbb8f8a156.zip | |
i2c: mux: reg: wrong condition checked for of_address_to_resource return value
commit 22ebf00eb56fe77922de8138aa9af9996582c2b3 upstream.
of_address_to_resource return 0 on successful call but
devm_ioremap_resource is called only if it returns non-zero value
Signed-off-by: Lukasz Gemborowski <lukasz.gemborowski@nokia.com>
Reviewed-by: Alexander Sverdlin <alexander.sverdlin@nokia.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/i2c/muxes/i2c-mux-reg.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/i2c/muxes/i2c-mux-reg.c b/drivers/i2c/muxes/i2c-mux-reg.c index 5fbd5bd0878f..49fc2c7e560a 100644 --- a/drivers/i2c/muxes/i2c-mux-reg.c +++ b/drivers/i2c/muxes/i2c-mux-reg.c @@ -150,7 +150,7 @@ static int i2c_mux_reg_probe_dt(struct regmux *mux, mux->data.idle_in_use = true; /* map address from "reg" if exists */ - if (of_address_to_resource(np, 0, &res)) { + if (of_address_to_resource(np, 0, &res) == 0) { mux->data.reg_size = resource_size(&res); mux->data.reg = devm_ioremap_resource(&pdev->dev, &res); if (IS_ERR(mux->data.reg)) |