diff options
| author | Nicholas Mc Guire <hofrat@osadl.org> | 2015-02-01 06:15:46 -0500 |
|---|---|---|
| committer | Brian Norris <computersforpeace@gmail.com> | 2015-03-30 18:08:04 -0700 |
| commit | 219a8d13dd2bd0536e359405d046bdce9cc9d134 (patch) | |
| tree | caf87f4379d4b9f5a9a3c45a0d5f1bba11bb28d5 /drivers | |
| parent | dc6525c61f0fc1e41611d91134f56ed2c297feac (diff) | |
| download | lwn-219a8d13dd2bd0536e359405d046bdce9cc9d134.tar.gz lwn-219a8d13dd2bd0536e359405d046bdce9cc9d134.zip | |
mtd: fsl-quadspi: cleanup wait_for_completion return handling
return type of wait_for_completion_timeout is unsigned long not int, this
patch uses the return value of wait_for_completion_timeout in the condition
directly rather than adding a additional appropriately typed variable.
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Acked-by: Han Xu <han.xu@freescale.com>
Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/mtd/spi-nor/fsl-quadspi.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c index c01dd1611888..5d5d36272bb5 100644 --- a/drivers/mtd/spi-nor/fsl-quadspi.c +++ b/drivers/mtd/spi-nor/fsl-quadspi.c @@ -460,8 +460,7 @@ fsl_qspi_runcmd(struct fsl_qspi *q, u8 cmd, unsigned int addr, int len) writel((seqid << QUADSPI_IPCR_SEQID_SHIFT) | len, base + QUADSPI_IPCR); /* Wait for the interrupt. */ - err = wait_for_completion_timeout(&q->c, msecs_to_jiffies(1000)); - if (!err) { + if (!wait_for_completion_timeout(&q->c, msecs_to_jiffies(1000))) { dev_err(q->dev, "cmd 0x%.2x timeout, addr@%.8x, FR:0x%.8x, SR:0x%.8x\n", cmd, addr, readl(base + QUADSPI_FR), |