summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2012-08-13 19:57:03 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2012-10-02 10:30:21 -0700
commit3dd2f0bb418f24a3b9a0b9b93b1ba104c2e6d140 (patch)
treee8b8db0294445b7dd504a96917857a85efc4c40a /drivers
parent40fd8822f49ad6ac2b7a575e3b2020e7382db431 (diff)
downloadlwn-3dd2f0bb418f24a3b9a0b9b93b1ba104c2e6d140.tar.gz
lwn-3dd2f0bb418f24a3b9a0b9b93b1ba104c2e6d140.zip
xhci: Fix a logical vs bitwise AND bug
commit 052c7f9ffb0e95843e75448d02664459253f9ff8 upstream. The intent was to test whether the flag was set. This patch should be backported to stable kernels as old as 3.0, since it fixes a bug in commit e95829f474f0db3a4d940cae1423783edd966027 "xhci: Switch PPT ports to EHCI on shutdown.", which was marked for stable. Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/usb/host/xhci.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/host/xhci.c b/drivers/usb/host/xhci.c
index 4afe3af319dd..6467d79d760d 100644
--- a/drivers/usb/host/xhci.c
+++ b/drivers/usb/host/xhci.c
@@ -760,7 +760,7 @@ void xhci_shutdown(struct usb_hcd *hcd)
{
struct xhci_hcd *xhci = hcd_to_xhci(hcd);
- if (xhci->quirks && XHCI_SPURIOUS_REBOOT)
+ if (xhci->quirks & XHCI_SPURIOUS_REBOOT)
usb_disable_xhci_ports(to_pci_dev(hcd->self.controller));
spin_lock_irq(&xhci->lock);