diff options
| author | Alex Hung <alex.hung@canonical.com> | 2012-04-24 16:40:52 +0800 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2014-06-09 13:29:01 +0100 |
| commit | db1b95998148724046213339cb51c647e0e0825a (patch) | |
| tree | 7a9591bc1d83a9a329c7edf4f04207a6e90c89f7 /drivers | |
| parent | fa79aa5e1b89bb5ec90fbd757513e907ca970ba5 (diff) | |
| download | lwn-db1b95998148724046213339cb51c647e0e0825a.tar.gz lwn-db1b95998148724046213339cb51c647e0e0825a.zip | |
thinkpad-acpi: fix issuing duplicated key events for brightness up/down
commit ff413195e830541afeae469fc866ecd0319abd7e upstream.
The tp_features.bright_acpimode will not be set correctly for brightness
control because ACPI_VIDEO_HID will not be located in ACPI. As a result,
a duplicated key event will always be sent. acpi_video_backlight_support()
is sufficient to detect standard ACPI brightness control.
Signed-off-by: Alex Hung <alex.hung@canonical.com>
Signed-off-by: Matthew Garrett <mjg@redhat.com>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/platform/x86/thinkpad_acpi.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c index 8e6c4fafb3eb..2a8d6aa441c3 100644 --- a/drivers/platform/x86/thinkpad_acpi.c +++ b/drivers/platform/x86/thinkpad_acpi.c @@ -3405,7 +3405,7 @@ static int __init hotkey_init(struct ibm_init_struct *iibm) /* Do not issue duplicate brightness change events to * userspace. tpacpi_detect_brightness_capabilities() must have * been called before this point */ - if (tp_features.bright_acpimode && acpi_video_backlight_support()) { + if (acpi_video_backlight_support()) { pr_info("This ThinkPad has standard ACPI backlight " "brightness control, supported by the ACPI " "video driver\n"); |