diff options
| author | David Ward <david.ward@ll.mit.edu> | 2011-09-18 12:53:20 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-10-04 23:31:23 -0400 |
| commit | cb2d0f3e968bff7c6d262aca3e3ab8d4184e69b2 (patch) | |
| tree | 50a3469e32de0edaf3cd764715c5f6d474f571ab /drivers | |
| parent | 976d167615b64e14bc1491ca51d424e2ba9a5e84 (diff) | |
| download | lwn-cb2d0f3e968bff7c6d262aca3e3ab8d4184e69b2.tar.gz lwn-cb2d0f3e968bff7c6d262aca3e3ab8d4184e69b2.zip | |
macvlan/macvtap: Fix unicast between macvtap interfaces in bridge mode
Packets should always be forwarded to the lowerdev using dev_forward_skb.
vlan->forward is for packets being forwarded directly to another macvlan/
macvtap device (used for multicast in bridge mode).
Reported-and-tested-by: Shlomo Pongratz <shlomop@mellanox.com>
Signed-off-by: David Ward <david.ward@ll.mit.edu>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/macvlan.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index 05172c39a0ce..376e3e94bae0 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -239,7 +239,7 @@ static int macvlan_queue_xmit(struct sk_buff *skb, struct net_device *dev) dest = macvlan_hash_lookup(port, eth->h_dest); if (dest && dest->mode == MACVLAN_MODE_BRIDGE) { /* send to lowerdev first for its network taps */ - vlan->forward(vlan->lowerdev, skb); + dev_forward_skb(vlan->lowerdev, skb); return NET_XMIT_SUCCESS; } |