diff options
| author | Brian King <brking@linux.vnet.ibm.com> | 2011-09-28 05:33:43 +0000 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2011-09-29 00:32:11 -0400 |
| commit | 95de86cf5162f78bc5aea80d1a9e5a248196ffaf (patch) | |
| tree | 9b44a633e311240611fa18c7ca5e055c2af9250e /drivers | |
| parent | 676a1184e8afd4fed7948232df1ff91517400859 (diff) | |
| download | lwn-95de86cf5162f78bc5aea80d1a9e5a248196ffaf.tar.gz lwn-95de86cf5162f78bc5aea80d1a9e5a248196ffaf.zip | |
ibmveth: Fix oops on request_irq failure
If request_irq fails, the ibmveth driver will overwrite
the rc and end up returning a successful rc on its open
function, resulting in an oops later when a packet gets
sent and buffers are not allocated due to the failed open.
Signed-off-by: Brian King <brking@linux.vnet.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/net/ibmveth.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c index 8dd5fccef725..d393f1e764ed 100644 --- a/drivers/net/ibmveth.c +++ b/drivers/net/ibmveth.c @@ -636,8 +636,8 @@ static int ibmveth_open(struct net_device *netdev) netdev_err(netdev, "unable to request irq 0x%x, rc %d\n", netdev->irq, rc); do { - rc = h_free_logical_lan(adapter->vdev->unit_address); - } while (H_IS_LONG_BUSY(rc) || (rc == H_BUSY)); + lpar_rc = h_free_logical_lan(adapter->vdev->unit_address); + } while (H_IS_LONG_BUSY(lpar_rc) || (lpar_rc == H_BUSY)); goto err_out; } |