diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2015-01-15 12:21:21 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2015-03-18 13:31:33 +0100 |
| commit | f563d4825241ad7c9fd8fd3538efece0607d5869 (patch) | |
| tree | d8e67693937e1ffbc9055c6a3e8268655305b981 /drivers | |
| parent | 6831c3a878de7b749b82f8894e199ea8a9456a50 (diff) | |
| download | lwn-f563d4825241ad7c9fd8fd3538efece0607d5869.tar.gz lwn-f563d4825241ad7c9fd8fd3538efece0607d5869.zip | |
efi: Small leak on error in runtime map code
commit 86d68a58d00db3770735b5919ef2c6b12d7f06f3 upstream.
The "> 0" here should ">= 0" so we free map_entries[0].
Fixes: 926172d46038 ('efi: Export EFI runtime memory mapping to sysfs')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Dave Young <dyoung@redhat.com>
Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/firmware/efi/runtime-map.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/firmware/efi/runtime-map.c b/drivers/firmware/efi/runtime-map.c index 97cdd16a2169..c98b101a73ae 100644 --- a/drivers/firmware/efi/runtime-map.c +++ b/drivers/firmware/efi/runtime-map.c @@ -170,7 +170,7 @@ int __init efi_runtime_map_init(struct kobject *efi_kobj) return 0; out_add_entry: - for (j = i - 1; j > 0; j--) { + for (j = i - 1; j >= 0; j--) { entry = *(map_entries + j); kobject_put(&entry->kobj); } |