diff options
| author | Bruno Prémont <bonbons@linux-vserver.org> | 2010-02-26 13:02:04 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-03-02 14:55:22 -0800 |
| commit | cedf8a78421943441b9011ce7bcdab55f07d2ea6 (patch) | |
| tree | aaa828c89672f782a596abf5bc23b35f936ec9f9 /drivers | |
| parent | 124d255382ddd37ffa920e9f5183efa54bbfe4f2 (diff) | |
| download | lwn-cedf8a78421943441b9011ce7bcdab55f07d2ea6.tar.gz lwn-cedf8a78421943441b9011ce7bcdab55f07d2ea6.zip | |
USB: backlight, appledisplay: fix incomplete registration failure handling
On error while registering backlight, return it to caller instead of
returning 0.
Mark struct backlight_ops as const.
Signed-off-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/misc/appledisplay.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/misc/appledisplay.c b/drivers/usb/misc/appledisplay.c index 516079d703b4..4d2952f1fb13 100644 --- a/drivers/usb/misc/appledisplay.c +++ b/drivers/usb/misc/appledisplay.c @@ -179,7 +179,7 @@ static int appledisplay_bl_get_brightness(struct backlight_device *bd) return pdata->msgdata[1]; } -static struct backlight_ops appledisplay_bl_data = { +static const struct backlight_ops appledisplay_bl_data = { .get_brightness = appledisplay_bl_get_brightness, .update_status = appledisplay_bl_update_status, }; @@ -283,6 +283,7 @@ static int appledisplay_probe(struct usb_interface *iface, &appledisplay_bl_data); if (IS_ERR(pdata->bd)) { dev_err(&iface->dev, "Backlight registration failed\n"); + retval = PTR_ERR(pdata->bd); goto error; } |