diff options
| author | Johan Hovold <jhovold@gmail.com> | 2012-10-25 13:35:10 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-10-31 09:51:36 -0700 |
| commit | 52fb227a7bddeb94b1e3a630755b232ddfc8a741 (patch) | |
| tree | ae35500f4049db57c05e3882111ee0f8a5704044 /drivers | |
| parent | de3ca50ea7524819a881d841e73ffb0c2aed73f7 (diff) | |
| download | lwn-52fb227a7bddeb94b1e3a630755b232ddfc8a741.tar.gz lwn-52fb227a7bddeb94b1e3a630755b232ddfc8a741.zip | |
USB: mos7840: fix port-device leak in error path
commit 3eb55cc4ed88eee3b5230f66abcdbd2a91639eda upstream.
The driver set the usb-serial port pointers to NULL on errors in attach,
effectively preventing usb-serial core from decrementing the port ref
counters and releasing the port devices and associated data.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/serial/mos7840.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c index d79760c20f51..955b3fd4c031 100644 --- a/drivers/usb/serial/mos7840.c +++ b/drivers/usb/serial/mos7840.c @@ -2595,7 +2595,6 @@ error: kfree(mos7840_port->ctrl_buf); usb_free_urb(mos7840_port->control_urb); kfree(mos7840_port); - serial->port[i] = NULL; } return status; } |