diff options
| author | Sarah Sharp <sarah.a.sharp@linux.intel.com> | 2010-07-09 17:08:48 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-08-02 10:30:01 -0700 |
| commit | a4f16eede5fb267bb6c0026a4ce816cd715f3514 (patch) | |
| tree | ec44897f3bb1359cb5e2ef6217dc0d1769119d39 /drivers | |
| parent | b00bd2dbb54d1c89c258e5dcd3560113820ebe72 (diff) | |
| download | lwn-a4f16eede5fb267bb6c0026a4ce816cd715f3514.tar.gz lwn-a4f16eede5fb267bb6c0026a4ce816cd715f3514.zip | |
USB: Fix USB3.0 Port Speed Downgrade after port reset
commit 809cd1cb80d7dffe75dc94bc94ef2aab3dadc86a upstream.
Without this fix, a USB 3.0 port is downgraded to full speed after a port
reset of a configured device. The USB 3.0 terminations will be disabled
permanently, and USB 3.0 devices will always enumerate as full speed
devices, until the host controller is unplugged (if it is an ExpressCard)
or the computer is rebooted.
Fajun Chen traced this traced the speed downgrade issue to the port reset
and the interpretation of port status in USB hub driver code. The hub
code was not testing for the port being a SuperSpeed port, and it fell
through to the else case of Full Speed.
The following patch adds SuperSpeed mapping from the port status, and
fixes the speed downgrade issue.
Reported-by: Fajun Chen <fajun.chen@seagate.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/usb/core/hub.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c index bca268a6d2f6..3e28f9216fad 100644 --- a/drivers/usb/core/hub.c +++ b/drivers/usb/core/hub.c @@ -1971,6 +1971,8 @@ static int hub_port_wait_reset(struct usb_hub *hub, int port1, (portstatus & USB_PORT_STAT_ENABLE)) { if (hub_is_wusb(hub)) udev->speed = USB_SPEED_WIRELESS; + else if (portstatus & (1 << USB_PORT_FEAT_SUPERSPEED)) + udev->speed = USB_SPEED_SUPER; else if (portstatus & USB_PORT_STAT_HIGH_SPEED) udev->speed = USB_SPEED_HIGH; else if (portstatus & USB_PORT_STAT_LOW_SPEED) |