summaryrefslogtreecommitdiff
path: root/drivers
diff options
context:
space:
mode:
authorGreg Kroah-Hartman <gregkh@suse.de>2009-03-10 20:42:55 -0700
committerGreg Kroah-Hartman <gregkh@suse.de>2009-03-17 14:01:28 -0700
commit5b10916ea0a62920204517e1c4ce14560b4f96ab (patch)
treec119039aa73e1b47e07b1857d6cfa2efc11adad6 /drivers
parentee568b25ee9e160b32d1aef73d8b2ee9c05d34db (diff)
downloadlwn-5b10916ea0a62920204517e1c4ce14560b4f96ab.tar.gz
lwn-5b10916ea0a62920204517e1c4ce14560b4f96ab.zip
USB: usbtmc: fix stupid bug in open()
open() will never succeed, as we always return -ENODEV. Fix this obvious bug. Thanks to Jouni Ryno for reporting it. Reported-by: Jouni Ryno <Jouni.Ryno@fmi.fi> Cc: stable <stable@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/usb/class/usbtmc.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/class/usbtmc.c b/drivers/usb/class/usbtmc.c
index 0f5c05f6f9df..895a09839001 100644
--- a/drivers/usb/class/usbtmc.c
+++ b/drivers/usb/class/usbtmc.c
@@ -106,12 +106,13 @@ static int usbtmc_open(struct inode *inode, struct file *filp)
{
struct usb_interface *intf;
struct usbtmc_device_data *data;
- int retval = -ENODEV;
+ int retval = 0;
intf = usb_find_interface(&usbtmc_driver, iminor(inode));
if (!intf) {
printk(KERN_ERR KBUILD_MODNAME
": can not find device for minor %d", iminor(inode));
+ retval = -ENODEV;
goto exit;
}