diff options
| author | Yang Li <yang.lee@linux.alibaba.com> | 2021-06-07 16:40:36 +0800 |
|---|---|---|
| committer | Jon Mason <jdmason@kudzu.us> | 2021-09-04 18:36:04 -0400 |
| commit | 0097ae5f7af5684f961a5f803ff7ad3e6f933668 (patch) | |
| tree | b0acc2ba117da103299139bc9508ac896ee8ec20 /drivers | |
| parent | 319f83ac98d7afaabab84ce5281a819a358b9895 (diff) | |
| download | lwn-0097ae5f7af5684f961a5f803ff7ad3e6f933668.tar.gz lwn-0097ae5f7af5684f961a5f803ff7ad3e6f933668.zip | |
NTB: perf: Fix an error code in perf_setup_inbuf()
When the function IS_ALIGNED() returns false, the value of ret is 0.
So, we set ret to -EINVAL to indicate this error.
Clean up smatch warning:
drivers/ntb/test/ntb_perf.c:602 perf_setup_inbuf() warn: missing error
code 'ret'.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Reviewed-by: Serge Semin <fancer.lancer@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/ntb/test/ntb_perf.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/ntb/test/ntb_perf.c b/drivers/ntb/test/ntb_perf.c index 89df1350fefd..65e1e5cf1b29 100644 --- a/drivers/ntb/test/ntb_perf.c +++ b/drivers/ntb/test/ntb_perf.c @@ -598,6 +598,7 @@ static int perf_setup_inbuf(struct perf_peer *peer) return -ENOMEM; } if (!IS_ALIGNED(peer->inbuf_xlat, xlat_align)) { + ret = -EINVAL; dev_err(&perf->ntb->dev, "Unaligned inbuf allocated\n"); goto err_free_inbuf; } |