diff options
| author | Jason Wang <jasowang@redhat.com> | 2015-08-06 13:54:21 +0800 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2015-08-06 10:40:35 +0300 |
| commit | df4198b1e0c4a7d1adde1e5c2ceb67ac10b391bb (patch) | |
| tree | 7a2f88d1e80de2f14e6cf43a12ecf2073dc1f2ca /drivers/virtio/virtio_input.c | |
| parent | 74d33293e467df61de1b1d8b2fbe29e550dec33b (diff) | |
| download | lwn-df4198b1e0c4a7d1adde1e5c2ceb67ac10b391bb.tar.gz lwn-df4198b1e0c4a7d1adde1e5c2ceb67ac10b391bb.zip | |
virtio-input: reset device and detach unused during remove
Spec requires a device reset during cleanup, so do it and avoid warn
in virtio core. And detach unused buffers to avoid memory leak.
Signed-off-by: Jason Wang <jasowang@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'drivers/virtio/virtio_input.c')
| -rw-r--r-- | drivers/virtio/virtio_input.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/virtio/virtio_input.c b/drivers/virtio/virtio_input.c index 60e2a1677563..c96944b59856 100644 --- a/drivers/virtio/virtio_input.c +++ b/drivers/virtio/virtio_input.c @@ -313,6 +313,7 @@ err_init_vq: static void virtinput_remove(struct virtio_device *vdev) { struct virtio_input *vi = vdev->priv; + void *buf; unsigned long flags; spin_lock_irqsave(&vi->lock, flags); @@ -320,6 +321,9 @@ static void virtinput_remove(struct virtio_device *vdev) spin_unlock_irqrestore(&vi->lock, flags); input_unregister_device(vi->idev); + vdev->config->reset(vdev); + while ((buf = virtqueue_detach_unused_buf(vi->sts)) != NULL) + kfree(buf); vdev->config->del_vqs(vdev); kfree(vi); } |