diff options
| author | Alexander Holler <holler@ahsoftware.de> | 2012-08-14 09:11:09 +0200 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2012-10-30 23:26:40 +0000 |
| commit | c03970223182c35eeff66d4ff319bf2d97f4efc3 (patch) | |
| tree | 881c5a460d5438be4a177fbc9a137b3abb3312ed /drivers/video | |
| parent | 20e6199e93250b6a6506f65c07e18fb18ad382ab (diff) | |
| download | lwn-c03970223182c35eeff66d4ff319bf2d97f4efc3.tar.gz lwn-c03970223182c35eeff66d4ff319bf2d97f4efc3.zip | |
video/udlfb: fix line counting in fb_write
commit b8c4321f3d194469007f5f5f2b34ec278c264a04 upstream.
Line 0 and 1 were both written to line 0 (on the display) and all subsequent
lines had an offset of -1. The result was that the last line on the display
was never overwritten by writes to /dev/fbN.
Signed-off-by: Alexander Holler <holler@ahsoftware.de>
Acked-by: Bernie Thompson <bernie@plugable.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'drivers/video')
| -rw-r--r-- | drivers/video/udlfb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/video/udlfb.c b/drivers/video/udlfb.c index 41746bbe5c0e..cb5988f15d03 100644 --- a/drivers/video/udlfb.c +++ b/drivers/video/udlfb.c @@ -646,7 +646,7 @@ static ssize_t dlfb_ops_write(struct fb_info *info, const char __user *buf, result = fb_sys_write(info, buf, count, ppos); if (result > 0) { - int start = max((int)(offset / info->fix.line_length) - 1, 0); + int start = max((int)(offset / info->fix.line_length), 0); int lines = min((u32)((result / info->fix.line_length) + 1), (u32)info->var.yres); |