diff options
| author | Julia Lawall <Julia.Lawall@lip6.fr> | 2012-08-19 10:44:24 +0200 |
|---|---|---|
| committer | Florian Tobias Schandinat <FlorianSchandinat@gmx.de> | 2012-08-23 13:21:48 +0000 |
| commit | 11bce6459fa3b9d7768a0a0d71c695e85f398c55 (patch) | |
| tree | ddc19df28bf1b86e4a9cfa587e53d63d5f940201 /drivers/video/sunxvr2500.c | |
| parent | 9ac5de0c575ee10739fd1c1a4bcedab7b0dde631 (diff) | |
| download | lwn-11bce6459fa3b9d7768a0a0d71c695e85f398c55.tar.gz lwn-11bce6459fa3b9d7768a0a0d71c695e85f398c55.zip | |
drivers/video/sunxvr2500.c: fix error return code
Initialize return variable before exiting on an error path.
A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)
// <smpl>
(
if@p1 (\(ret < 0\|ret != 0\))
{ ... return ret; }
|
ret@p1 = 0
)
... when != ret = e1
when != &ret
*if(...)
{
... when != ret = e2
when forall
return ret;
}
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Diffstat (limited to 'drivers/video/sunxvr2500.c')
| -rw-r--r-- | drivers/video/sunxvr2500.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/video/sunxvr2500.c b/drivers/video/sunxvr2500.c index 5848436c19da..7fbcba86d1a2 100644 --- a/drivers/video/sunxvr2500.c +++ b/drivers/video/sunxvr2500.c @@ -181,8 +181,10 @@ static int __devinit s3d_pci_register(struct pci_dev *pdev, sp->fb_size = info->fix.line_length * sp->height; sp->fb_base = ioremap(sp->fb_base_phys, sp->fb_size); - if (!sp->fb_base) + if (!sp->fb_base) { + err = -ENOMEM; goto err_release_pci; + } err = s3d_set_fbinfo(sp); if (err) |