diff options
| author | Venkatesh Srinivas <venkateshs@google.com> | 2014-02-24 14:13:32 -0800 |
|---|---|---|
| committer | Nicholas Bellinger <nab@linux-iscsi.org> | 2014-02-24 16:19:43 -0800 |
| commit | 7fe412d07d881020022a188b95c63a19b651a391 (patch) | |
| tree | e2eeec574e7abfbfbed2a74094d1bf7a7d58490a /drivers/vhost/scsi.c | |
| parent | 6f58c780e5a5b43a6d2121e0d43cdcba1d3cc5fc (diff) | |
| download | lwn-7fe412d07d881020022a188b95c63a19b651a391.tar.gz lwn-7fe412d07d881020022a188b95c63a19b651a391.zip | |
vhost/scsi: Check LUN structure byte 0 is set to 1, per spec
The virtio spec requires byte 0 of the virtio-scsi LUN structure
to be '1'.
Signed-off-by: Venkatesh Srinivas <venkateshs@google.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'drivers/vhost/scsi.c')
| -rw-r--r-- | drivers/vhost/scsi.c | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/drivers/vhost/scsi.c b/drivers/vhost/scsi.c index 0a025b8e2a12..e48d4a672580 100644 --- a/drivers/vhost/scsi.c +++ b/drivers/vhost/scsi.c @@ -1001,6 +1001,12 @@ vhost_scsi_handle_vq(struct vhost_scsi *vs, struct vhost_virtqueue *vq) break; } + /* virtio-scsi spec requires byte 0 of the lun to be 1 */ + if (unlikely(v_req.lun[0] != 1)) { + vhost_scsi_send_bad_target(vs, vq, head, out); + continue; + } + /* Extract the tpgt */ target = v_req.lun[1]; tpg = ACCESS_ONCE(vs_tpg[target]); |