diff options
| author | Alex Williamson <alex.williamson@redhat.com> | 2024-03-08 16:05:26 -0700 |
|---|---|---|
| committer | Alex Williamson <alex.williamson@redhat.com> | 2024-03-11 13:08:52 -0600 |
| commit | fcdc0d3d40bc26c105acf8467f7d9018970944ae (patch) | |
| tree | f8dc61496e0d422b01ff9db62cf81790c36f9b06 /drivers/vfio | |
| parent | 18c198c96a815c962adc2b9b77909eec0be7df4d (diff) | |
| download | lwn-fcdc0d3d40bc26c105acf8467f7d9018970944ae.tar.gz lwn-fcdc0d3d40bc26c105acf8467f7d9018970944ae.zip | |
vfio/platform: Disable virqfds on cleanup
irqfds for mask and unmask that are not specifically disabled by the
user are leaked. Remove any irqfds during cleanup
Cc: Eric Auger <eric.auger@redhat.com>
Cc: <stable@vger.kernel.org>
Fixes: a7fa7c77cf15 ("vfio/platform: implement IRQ masking/unmasking via an eventfd")
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Link: https://lore.kernel.org/r/20240308230557.805580-6-alex.williamson@redhat.com
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'drivers/vfio')
| -rw-r--r-- | drivers/vfio/platform/vfio_platform_irq.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/vfio/platform/vfio_platform_irq.c b/drivers/vfio/platform/vfio_platform_irq.c index 61a1bfb68ac7..e5dcada9e86c 100644 --- a/drivers/vfio/platform/vfio_platform_irq.c +++ b/drivers/vfio/platform/vfio_platform_irq.c @@ -321,8 +321,11 @@ void vfio_platform_irq_cleanup(struct vfio_platform_device *vdev) { int i; - for (i = 0; i < vdev->num_irqs; i++) + for (i = 0; i < vdev->num_irqs; i++) { + vfio_virqfd_disable(&vdev->irqs[i].mask); + vfio_virqfd_disable(&vdev->irqs[i].unmask); vfio_set_trigger(vdev, i, -1, NULL); + } vdev->num_irqs = 0; kfree(vdev->irqs); |