diff options
author | Alex Williamson <alex.williamson@redhat.com> | 2013-08-22 10:33:41 -0600 |
---|---|---|
committer | Alex Williamson <alex.williamson@redhat.com> | 2013-08-22 10:33:41 -0600 |
commit | 5d042fbdbb2df46c9185942a0c6fe280906ba70c (patch) | |
tree | 87483859f6ac5cdd04209e6e0b16ec131766232c /drivers/vfio | |
parent | a5d550703d2c2f0f9fc5fd4a249efa8984dc9353 (diff) | |
download | lwn-5d042fbdbb2df46c9185942a0c6fe280906ba70c.tar.gz lwn-5d042fbdbb2df46c9185942a0c6fe280906ba70c.zip |
vfio: Add O_CLOEXEC flag to vfio device fd
Add the default O_CLOEXEC flag for device file descriptors. This is
generally considered a safer option as it allows the user a race free
option to decide whether file descriptors are inherited across exec,
with the default avoiding file descriptor leaks.
Reported-by: Yann Droneaud <ydroneaud@opteya.com>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'drivers/vfio')
-rw-r--r-- | drivers/vfio/vfio.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/vfio/vfio.c b/drivers/vfio/vfio.c index 75c16cc5921a..1eab4ace0671 100644 --- a/drivers/vfio/vfio.c +++ b/drivers/vfio/vfio.c @@ -1109,7 +1109,7 @@ static int vfio_group_get_device_fd(struct vfio_group *group, char *buf) * We can't use anon_inode_getfd() because we need to modify * the f_mode flags directly to allow more than just ioctls */ - ret = get_unused_fd_flags(0); + ret = get_unused_fd_flags(O_CLOEXEC); if (ret < 0) { device->ops->release(device->device_data); break; |