diff options
| author | Alexey Kardashevskiy <aik@ozlabs.ru> | 2015-03-12 14:43:12 +1100 |
|---|---|---|
| committer | Alex Williamson <alex.williamson@redhat.com> | 2015-03-12 09:51:38 -0600 |
| commit | ec76f4007079469e86e2e44c3e5d1d11086de9d6 (patch) | |
| tree | b7011efa16c38666d9c87f8cd8b7189cc2659be0 /drivers/vfio/pci | |
| parent | 9eccca0843205f87c00404b663188b88eb248051 (diff) | |
| download | lwn-ec76f4007079469e86e2e44c3e5d1d11086de9d6.tar.gz lwn-ec76f4007079469e86e2e44c3e5d1d11086de9d6.zip | |
vfio-pci: Add missing break to enable VFIO_PCI_ERR_IRQ_INDEX
This adds a missing break statement to VFIO_DEVICE_SET_IRQS handler
without which vfio_pci_set_err_trigger() would never be called.
While we are here, add another "break" to VFIO_PCI_REQ_IRQ_INDEX case
so if we add more indexes later, we won't miss it.
Fixes: 6140a8f56238 ("vfio-pci: Add device request interface")
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Alex Williamson <alex.williamson@redhat.com>
Diffstat (limited to 'drivers/vfio/pci')
| -rw-r--r-- | drivers/vfio/pci/vfio_pci_intrs.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/vfio/pci/vfio_pci_intrs.c b/drivers/vfio/pci/vfio_pci_intrs.c index f88bfdf5b6a0..2027a27546ef 100644 --- a/drivers/vfio/pci/vfio_pci_intrs.c +++ b/drivers/vfio/pci/vfio_pci_intrs.c @@ -868,12 +868,14 @@ int vfio_pci_set_irqs_ioctl(struct vfio_pci_device *vdev, uint32_t flags, func = vfio_pci_set_err_trigger; break; } + break; case VFIO_PCI_REQ_IRQ_INDEX: switch (flags & VFIO_IRQ_SET_ACTION_TYPE_MASK) { case VFIO_IRQ_SET_ACTION_TRIGGER: func = vfio_pci_set_req_trigger; break; } + break; } if (!func) |