diff options
| author | Dan Carpenter <dan.carpenter@linaro.org> | 2024-07-12 09:06:12 -0500 |
|---|---|---|
| committer | Michael S. Tsirkin <mst@redhat.com> | 2024-07-17 05:43:20 -0400 |
| commit | e14f480df7fbcb0c84ce9142c861701495d9b6e2 (patch) | |
| tree | 8597a03f791186e21c169b73056ddcc1fe199fa2 /drivers/vdpa | |
| parent | 69eced9eb49aa6a55c9ef5745b0826fe0b74ff0f (diff) | |
| download | lwn-e14f480df7fbcb0c84ce9142c861701495d9b6e2.tar.gz lwn-e14f480df7fbcb0c84ce9142c861701495d9b6e2.zip | |
vdpa/octeon_ep: Fix error code in octep_process_mbox()
Return -EINVAL for invalid signatures. Don't return success.
Fixes: 8b6c724cdab8 ("virtio: vdpa: vDPA driver for Marvell OCTEON DPU devices")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Message-Id: <623e885b-1a05-479e-ab97-01bcf10bf5b8@stanley.mountain>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Diffstat (limited to 'drivers/vdpa')
| -rw-r--r-- | drivers/vdpa/octeon_ep/octep_vdpa_hw.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/vdpa/octeon_ep/octep_vdpa_hw.c b/drivers/vdpa/octeon_ep/octep_vdpa_hw.c index 7fa0491bb201..11bd76ae18cf 100644 --- a/drivers/vdpa/octeon_ep/octep_vdpa_hw.c +++ b/drivers/vdpa/octeon_ep/octep_vdpa_hw.c @@ -140,7 +140,7 @@ static int octep_process_mbox(struct octep_hw *oct_hw, u16 id, u16 qid, void *bu val = octep_read_sig(mbox); if ((val & 0xFFFF) != MBOX_RSP_SIG) { dev_warn(&pdev->dev, "Invalid Signature from mbox : %d response\n", id); - return ret; + return -EINVAL; } val = octep_read_sts(mbox); |