diff options
| author | Jiri Slaby <jslaby@suse.cz> | 2011-02-28 10:34:06 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2011-03-23 13:03:46 -0700 |
| commit | 0a04fbe5bb3d98d3ee553e9fec49ac9e16cc3217 (patch) | |
| tree | 4a99c368fa62cc9127883c5bc4ccfd555cd4b694 /drivers/usb | |
| parent | 366a91fbe3eeaf11c7bc380e854c7096bcb976dd (diff) | |
| download | lwn-0a04fbe5bb3d98d3ee553e9fec49ac9e16cc3217.tar.gz lwn-0a04fbe5bb3d98d3ee553e9fec49ac9e16cc3217.zip | |
USB: serial/kobil_sct, fix potential tty NULL dereference
commit 6960f40a954619857e7095a6179eef896f297077 upstream.
Make sure that we check the return value of tty_port_tty_get.
Sometimes it may return NULL and we later dereference that.
The only place here is in kobil_read_int_callback, so fix it.
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/serial/kobil_sct.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c index bd5bd8589e04..b382d9a0274d 100644 --- a/drivers/usb/serial/kobil_sct.c +++ b/drivers/usb/serial/kobil_sct.c @@ -372,7 +372,7 @@ static void kobil_read_int_callback(struct urb *urb) } tty = tty_port_tty_get(&port->port); - if (urb->actual_length) { + if (tty && urb->actual_length) { /* BEGIN DEBUG */ /* |