diff options
| author | John Youn <John.Youn@synopsys.com> | 2010-08-09 13:56:11 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2010-08-26 16:44:09 -0700 |
| commit | b9b1463afe574c5ce6d824305ea2fe817d8ccc02 (patch) | |
| tree | 525899d35bf3dc1f3227f3a24c7471d5a6ea0dbe /drivers/usb | |
| parent | aced8781afb05d5d0d9ce6304c24ac34861585b7 (diff) | |
| download | lwn-b9b1463afe574c5ce6d824305ea2fe817d8ccc02.tar.gz lwn-b9b1463afe574c5ce6d824305ea2fe817d8ccc02.zip | |
USB: xhci: Remove buggy assignment in next_trb()
commit a1669b2c64a9c8b031e0ac5cbf2692337a577f7c upstream.
The code to increment the TRB pointer has a slight ambiguity that could
lead to a bug on different compilers. The ANSI C specification does not
specify the precedence of the assignment operator over the postfix
operator. gcc 4.4 produced the correct code (increment the pointer and
assign the value), but a MIPS compiler that one of John's clients used
assigned the old (unincremented) value.
Remove the unnecessary assignment to make all compilers produce the
correct assembly.
Signed-off-by: John Youn <johnyoun@synopsys.com>
Signed-off-by: Sarah Sharp <sarah.a.sharp@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb')
| -rw-r--r-- | drivers/usb/host/xhci-ring.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c index 40cba25b1237..632a7b60ed10 100644 --- a/drivers/usb/host/xhci-ring.c +++ b/drivers/usb/host/xhci-ring.c @@ -125,7 +125,7 @@ static void next_trb(struct xhci_hcd *xhci, *seg = (*seg)->next; *trb = ((*seg)->trbs); } else { - *trb = (*trb)++; + (*trb)++; } } |