diff options
| author | Adrian Bunk <bunk@stusta.de> | 2007-07-31 00:28:22 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@suse.de> | 2007-10-12 14:54:59 -0700 |
| commit | a96173af521a173f45d3a27fa24265081f12e978 (patch) | |
| tree | a3198b3407b09e041aa0b8f7383b18225799cf2e /drivers/usb/storage/shuttle_usbat.c | |
| parent | efc9052e01fd316b7bd6b108feff7689c927ebe9 (diff) | |
| download | lwn-a96173af521a173f45d3a27fa24265081f12e978.tar.gz lwn-a96173af521a173f45d3a27fa24265081f12e978.zip | |
USB: Storage: usbat_check_status(): fix check-after-use
The Coverity checker spotted that we have already oops'ed if "us"
was NULL.
Since "us" can't be NULL in the only caller this patch removes the
NULL check.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
Signed-off-by: Matthew Dharm <mdharm-usb@one-eyed-alien.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Diffstat (limited to 'drivers/usb/storage/shuttle_usbat.c')
| -rw-r--r-- | drivers/usb/storage/shuttle_usbat.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/drivers/usb/storage/shuttle_usbat.c b/drivers/usb/storage/shuttle_usbat.c index 5e27297c0175..17ca4d73577b 100644 --- a/drivers/usb/storage/shuttle_usbat.c +++ b/drivers/usb/storage/shuttle_usbat.c @@ -190,9 +190,6 @@ static int usbat_check_status(struct us_data *us) unsigned char *reply = us->iobuf; int rc; - if (!us) - return USB_STOR_TRANSPORT_ERROR; - rc = usbat_get_status(us, reply); if (rc != USB_STOR_XFER_GOOD) return USB_STOR_TRANSPORT_FAILED; |