diff options
| author | Uwe Kleine-König <uwe@kleine-koenig.org> | 2021-02-08 15:31:49 +0100 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2021-02-09 13:13:58 +0100 |
| commit | c5d1448fa353242635fa3e1fed6ab4558e0e7d9a (patch) | |
| tree | d74c1132f17bd3f0ad29a6565e887f541169bd00 /drivers/usb/serial/upd78f0730.c | |
| parent | a54af1b7d667927162d13083a8e2d470fb8722e2 (diff) | |
| download | lwn-c5d1448fa353242635fa3e1fed6ab4558e0e7d9a.tar.gz lwn-c5d1448fa353242635fa3e1fed6ab4558e0e7d9a.zip | |
USB: serial: make remove callback return void
All usb_serial drivers return 0 in their remove callbacks and driver
core ignores the value returned by usb_serial_device_remove(). So change
the remove callback to return void and return 0 unconditionally in
usb_serial_device_remove().
Signed-off-by: Uwe Kleine-König <uwe@kleine-koenig.org>
Link: https://lore.kernel.org/r/20210208143149.963644-2-uwe@kleine-koenig.org
Signed-off-by: Johan Hovold <johan@kernel.org>
Diffstat (limited to 'drivers/usb/serial/upd78f0730.c')
| -rw-r--r-- | drivers/usb/serial/upd78f0730.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/usb/serial/upd78f0730.c b/drivers/usb/serial/upd78f0730.c index 1ca9c1881621..26d7b003b7e3 100644 --- a/drivers/usb/serial/upd78f0730.c +++ b/drivers/usb/serial/upd78f0730.c @@ -171,15 +171,13 @@ static int upd78f0730_port_probe(struct usb_serial_port *port) return 0; } -static int upd78f0730_port_remove(struct usb_serial_port *port) +static void upd78f0730_port_remove(struct usb_serial_port *port) { struct upd78f0730_port_private *private; private = usb_get_serial_port_data(port); mutex_destroy(&private->lock); kfree(private); - - return 0; } static int upd78f0730_tiocmget(struct tty_struct *tty) |