diff options
| author | Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> | 2012-12-09 21:06:37 -0800 |
|---|---|---|
| committer | Felipe Balbi <balbi@ti.com> | 2012-12-13 11:58:44 +0200 |
| commit | e0b64ce6fe0a9d4ce8cf97fea7fe5ec7125dea30 (patch) | |
| tree | a453a6d529acd8958a58fa433142edf81afd7e43 /drivers/usb/renesas_usbhs/mod_host.c | |
| parent | d9fa298f215e050dbb28a6f75fe76459ebd2e7f0 (diff) | |
| download | lwn-e0b64ce6fe0a9d4ce8cf97fea7fe5ec7125dea30.tar.gz lwn-e0b64ce6fe0a9d4ce8cf97fea7fe5ec7125dea30.zip | |
usb: renesas_usbhs: mod_host: fixup usbhsh_ureq_free() timing
usbhsh_ureq_free() free ureq which includes ubshs_pkt.
But current driver used usbhs_pkt after freed ureq.
This patch fixup this bug.
Special thanks to Chen
Reported-by: Chen Gang <gang.chen@asianux.com>
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Diffstat (limited to 'drivers/usb/renesas_usbhs/mod_host.c')
| -rw-r--r-- | drivers/usb/renesas_usbhs/mod_host.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/renesas_usbhs/mod_host.c b/drivers/usb/renesas_usbhs/mod_host.c index 3d3cd6ca2689..b86815421c8d 100644 --- a/drivers/usb/renesas_usbhs/mod_host.c +++ b/drivers/usb/renesas_usbhs/mod_host.c @@ -661,9 +661,10 @@ static void usbhsh_queue_done(struct usbhs_priv *priv, struct usbhs_pkt *pkt) status = -ESHUTDOWN; urb->actual_length = pkt->actual; - usbhsh_ureq_free(hpriv, ureq); usbhsh_endpoint_sequence_save(hpriv, urb, pkt); + usbhsh_ureq_free(hpriv, ureq); + usbhsh_pipe_detach(hpriv, usbhsh_ep_to_uep(urb->ep)); usb_hcd_unlink_urb_from_ep(hcd, urb); |