diff options
| author | Tomoya MORINAGA <tomoya.rohm@gmail.com> | 2012-01-12 11:27:05 +0900 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2012-04-22 16:21:42 -0700 |
| commit | 21c7c5809c9d11ad3c1cdba9f0935b97ae4ccdd3 (patch) | |
| tree | 5ed61a1430dd47202f2605e2a0823545dd4da1fa /drivers/usb/gadget | |
| parent | a1fdbba66d5a3a7ec0cc78ac8c1f19d99d37454e (diff) | |
| download | lwn-21c7c5809c9d11ad3c1cdba9f0935b97ae4ccdd3.tar.gz lwn-21c7c5809c9d11ad3c1cdba9f0935b97ae4ccdd3.zip | |
usb: gadget: pch_udc: Fix disconnect issue
commit c50a3bff0edb0acd49d8033a12ea4668e09a31ad upstream.
ISSUE:
When the driver notifies a gadget of a disconnect event, a system
rarely freezes.
CAUSE:
When the driver calls dev->driver->disconnect(), it is not calling
spin_unlock().
Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/usb/gadget')
| -rw-r--r-- | drivers/usb/gadget/pch_udc.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/usb/gadget/pch_udc.c b/drivers/usb/gadget/pch_udc.c index 68dbcc3e4cc2..2b731f3efab8 100644 --- a/drivers/usb/gadget/pch_udc.c +++ b/drivers/usb/gadget/pch_udc.c @@ -2338,8 +2338,11 @@ static void pch_udc_svc_ur_interrupt(struct pch_udc_dev *dev) /* Complete request queue */ empty_req_queue(ep); } - if (dev->driver && dev->driver->disconnect) + if (dev->driver && dev->driver->disconnect) { + spin_unlock(&dev->lock); dev->driver->disconnect(&dev->gadget); + spin_lock(&dev->lock); + } } /** |