diff options
| author | Johan Hovold <jhovold@gmail.com> | 2013-09-10 12:50:49 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-10-05 07:17:55 -0700 |
| commit | 7c429067c4df70216638104c890bf6cfe4fdcf95 (patch) | |
| tree | 390a79e5e69ff5690ba429318009e1d9576d525e /drivers/tty | |
| parent | c1fbde0427058453c32b39d4022f276d485489c6 (diff) | |
| download | lwn-7c429067c4df70216638104c890bf6cfe4fdcf95.tar.gz lwn-7c429067c4df70216638104c890bf6cfe4fdcf95.zip | |
serial: pch_uart: fix tty-kref leak in rx-error path
commit fc0919c68cb2f75bb1af759315f9d7e2a9443c28 upstream.
Fix tty-kref leak introduced by commit 384e301e ("pch_uart: fix a
deadlock when pch_uart as console") which never put its tty reference.
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
| -rw-r--r-- | drivers/tty/serial/pch_uart.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c index 572d48189de9..591cadb0bcc3 100644 --- a/drivers/tty/serial/pch_uart.c +++ b/drivers/tty/serial/pch_uart.c @@ -1071,6 +1071,8 @@ static void pch_uart_err_ir(struct eg20t_port *priv, unsigned int lsr) if (tty == NULL) { for (i = 0; error_msg[i] != NULL; i++) dev_err(&priv->pdev->dev, error_msg[i]); + } else { + tty_kref_put(tty); } } |