diff options
| author | Jiri Slaby <jirislaby@kernel.org> | 2023-06-21 12:16:07 +0200 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-06-21 17:57:29 +0200 |
| commit | e1488513abee9f34a7d0f3bd57ee65d2a7e13426 (patch) | |
| tree | 10ce5695f07e3312a2497fde9e59b867005a568c /drivers/tty | |
| parent | 777e456852f729fa2942187a43a8eafbaecc6876 (diff) | |
| download | lwn-e1488513abee9f34a7d0f3bd57ee65d2a7e13426.tar.gz lwn-e1488513abee9f34a7d0f3bd57ee65d2a7e13426.zip | |
tty_audit: use kzalloc() in tty_audit_buf_alloc()
tty_audit_buf_alloc() manually erases most of the entries after
kmalloc(). So use kzalloc() and remove the manual sets to zero.
That way, we are sure that we do not omit anything.
Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
Link: https://lore.kernel.org/r/20230621101611.10580-3-jirislaby@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty')
| -rw-r--r-- | drivers/tty/tty_audit.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/tty/tty_audit.c b/drivers/tty/tty_audit.c index b98b1aef5f6f..43f34465b9df 100644 --- a/drivers/tty/tty_audit.c +++ b/drivers/tty/tty_audit.c @@ -33,16 +33,16 @@ static struct tty_audit_buf *tty_audit_buf_alloc(void) { struct tty_audit_buf *buf; - buf = kmalloc(sizeof(*buf), GFP_KERNEL); + buf = kzalloc(sizeof(*buf), GFP_KERNEL); if (!buf) goto err; + buf->data = kmalloc(N_TTY_BUF_SIZE, GFP_KERNEL); if (!buf->data) goto err_buf; + mutex_init(&buf->mutex); - buf->dev = MKDEV(0, 0); - buf->icanon = 0; - buf->valid = 0; + return buf; err_buf: |