summaryrefslogtreecommitdiff
path: root/drivers/tty/sysrq.c
diff options
context:
space:
mode:
authorJohan Hovold <johan@kernel.org>2021-10-07 15:31:46 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-10-07 16:22:29 +0200
commitd02b006b29de14968ba4afa998bede0d55469e29 (patch)
tree06687a0bff6efa9839ba72b4cd2554d3a19e0a61 /drivers/tty/sysrq.c
parent32262e2e429cdb31f9e957e997d53458762931b7 (diff)
downloadlwn-d02b006b29de14968ba4afa998bede0d55469e29.tar.gz
lwn-d02b006b29de14968ba4afa998bede0d55469e29.zip
Revert "serial: 8250: Fix reporting real baudrate value in c_ospeed field"
This reverts commit 32262e2e429cdb31f9e957e997d53458762931b7. The commit in question claims to determine the inverse of serial8250_get_divisor() but failed to notice that some drivers override the default implementation using a get_divisor() callback. This means that the computed line-speed values can be completely wrong and results in regular TCSETS requests failing (the incorrect values would also be passed to any overridden set_divisor() callback). Similarly, it also failed to honour the old (deprecated) ASYNC_SPD_FLAGS and would break applications relying on those when re-encoding the actual line speed. There are also at least two quirks, UART_BUG_QUOT and an OMAP1510 workaround, which were happily ignored and that are now broken. Finally, even if the offending commit were to be implemented correctly, this is a new feature and not something which should be backported to stable. Cc: Pali Rohár <pali@kernel.org> Fixes: 32262e2e429c ("serial: 8250: Fix reporting real baudrate value in c_ospeed field") Cc: stable <stable@vger.kernel.org> Signed-off-by: Johan Hovold <johan@kernel.org> Link: https://lore.kernel.org/r/20211007133146.28949-1-johan@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/tty/sysrq.c')
0 files changed, 0 insertions, 0 deletions