diff options
| author | Roland Dreier <roland@purestorage.com> | 2013-01-02 12:47:59 -0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2013-01-21 11:45:14 -0800 |
| commit | aa16959322c2c096ac050d8a970e1cf2d2b1cc35 (patch) | |
| tree | 8a4f501726a496b4a7805c719a073f8d745db58c /drivers/target | |
| parent | 4b77fd473bf78ec6ddd7c6f4d1f03582a4ec34b9 (diff) | |
| download | lwn-aa16959322c2c096ac050d8a970e1cf2d2b1cc35.tar.gz lwn-aa16959322c2c096ac050d8a970e1cf2d2b1cc35.zip | |
target: Release se_cmd when LUN lookup fails for TMR
commit 5a3b6fc0092c5f8dee7820064ee54d2631d48573 upstream.
When transport_lookup_tmr_lun() fails and we return a task management
response from target_complete_tmr_failure(), we need to call
transport_cmd_check_stop_to_fabric() to release the last ref to the
cmd after calling se_tfo->queue_tm_rsp(), or else we will never remove
the failed TMR from the session command list (and we'll end up waiting
forever when trying to tear down the session).
(nab: Fix minor compile breakage)
Signed-off-by: Roland Dreier <roland@purestorage.com>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/target_core_transport.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/target/target_core_transport.c b/drivers/target/target_core_transport.c index 69f3f7d53a04..f52e5a0041b4 100644 --- a/drivers/target/target_core_transport.c +++ b/drivers/target/target_core_transport.c @@ -1748,6 +1748,8 @@ static void target_complete_tmr_failure(struct work_struct *work) se_cmd->se_tmr_req->response = TMR_LUN_DOES_NOT_EXIST; se_cmd->se_tfo->queue_tm_rsp(se_cmd); + + transport_cmd_check_stop_to_fabric(se_cmd); } /** |