diff options
| author | Bodo Stroesser <bstroesser@ts.fujitsu.com> | 2020-04-08 15:26:10 +0200 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2020-04-13 14:00:41 -0400 |
| commit | 8fed04eb79a74cbf471dfaa755900a51b37273ab (patch) | |
| tree | 220c1de30de506a07256a6a80e49c239e83c378c /drivers/target | |
| parent | 13ef143ddd93a5c8ee1e721683786a82eb9b126d (diff) | |
| download | lwn-8fed04eb79a74cbf471dfaa755900a51b37273ab.tar.gz lwn-8fed04eb79a74cbf471dfaa755900a51b37273ab.zip | |
scsi: target: fix PR IN / READ FULL STATUS for FC
Creation of the response to READ FULL STATUS fails for FC based
reservations. Reason is the too high loop limit (< 24) in
fc_get_pr_transport_id(). The string representation of FC WWPN is 23 chars
long only ("11:22:33:44:55:66:77:88"). So when i is 23, the loop body is
executed a last time for the ending '\0' of the string and thus hex2bin()
reports an error.
Link: https://lore.kernel.org/r/20200408132610.14623-3-bstroesser@ts.fujitsu.com
Signed-off-by: Bodo Stroesser <bstroesser@ts.fujitsu.com>
Reviewed-by: Mike Christie <mchristi@redhat.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Diffstat (limited to 'drivers/target')
| -rw-r--r-- | drivers/target/target_core_fabric_lib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/target/target_core_fabric_lib.c b/drivers/target/target_core_fabric_lib.c index f5f673e128ef..1e031d81e59e 100644 --- a/drivers/target/target_core_fabric_lib.c +++ b/drivers/target/target_core_fabric_lib.c @@ -63,7 +63,7 @@ static int fc_get_pr_transport_id( * encoded TransportID. */ ptr = &se_nacl->initiatorname[0]; - for (i = 0; i < 24; ) { + for (i = 0; i < 23; ) { if (!strncmp(&ptr[i], ":", 1)) { i++; continue; |