diff options
| author | Larry Finger <Larry.Finger@lwfinger.net> | 2016-11-05 14:08:57 -0500 |
|---|---|---|
| committer | Kalle Valo <kvalo@codeaurora.org> | 2016-11-17 08:49:04 +0200 |
| commit | 8052d7245b6089992343c80b38b14dbbd8354651 (patch) | |
| tree | c0294c8f8cccbe59b594d048a78bacd0193f026a /drivers/ssb | |
| parent | e49656147359411fb7529a211e852e587e5970dd (diff) | |
| download | lwn-8052d7245b6089992343c80b38b14dbbd8354651.tar.gz lwn-8052d7245b6089992343c80b38b14dbbd8354651.zip | |
ssb: Fix error routine when fallback SPROM fails
When there is a CRC error in the SPROM read from the device, the code
attempts to handle a fallback SPROM. When this also fails, the driver
returns zero rather than an error code.
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Cc: Stable <stable@vger.kernel.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Diffstat (limited to 'drivers/ssb')
| -rw-r--r-- | drivers/ssb/pci.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/ssb/pci.c b/drivers/ssb/pci.c index 0f28c08fcb3c..77b551da5728 100644 --- a/drivers/ssb/pci.c +++ b/drivers/ssb/pci.c @@ -909,6 +909,7 @@ static int ssb_pci_sprom_get(struct ssb_bus *bus, if (err) { ssb_warn("WARNING: Using fallback SPROM failed (err %d)\n", err); + goto out_free; } else { ssb_dbg("Using SPROM revision %d provided by platform\n", sprom->revision); |