diff options
| author | Yang Yingliang <yangyingliang@huawei.com> | 2022-07-13 10:56:55 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2022-07-13 13:48:58 +0100 |
| commit | e82c6d62a1f2347cde69c169fcf37e4d26f89b98 (patch) | |
| tree | 01c4ee65fc2ada5e1a185bd1a0bc676259b73c1d /drivers/spi | |
| parent | cdb0cc9379f1b4fa5ea3e0492bacf8008f3f4e5a (diff) | |
| download | lwn-e82c6d62a1f2347cde69c169fcf37e4d26f89b98.tar.gz lwn-e82c6d62a1f2347cde69c169fcf37e4d26f89b98.zip | |
spi: microchip-core: fix UAF in mchp_corespi_remove()
When using devm_spi_register_master(), the unregister function will
be called in devres_release_all() which is called after ->remove(),
so remove spi_unregister_master() andspi_master_put().
Fixes: 9ac8d17694b6 ("spi: add support for microchip fpga spi controllers")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Link: https://lore.kernel.org/r/20220713025657.3524506-2-yangyingliang@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi-microchip-core.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c index b3083075cd36..c26767343176 100644 --- a/drivers/spi/spi-microchip-core.c +++ b/drivers/spi/spi-microchip-core.c @@ -595,8 +595,6 @@ static int mchp_corespi_remove(struct platform_device *pdev) struct mchp_corespi *spi = spi_master_get_devdata(master); mchp_corespi_disable_ints(spi); - spi_unregister_master(master); - spi_master_put(master); clk_disable_unprepare(spi->clk); mchp_corespi_disable(spi); |