diff options
| author | David Lechner <dlechner@baylibre.com> | 2024-07-08 20:05:28 -0500 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-07-09 17:42:31 +0100 |
| commit | c86a918b1bdba78fb155184f8d88dfba1e63335d (patch) | |
| tree | 6ae05673f983884441fac4c8bc2d2ad36bdfae70 /drivers/spi | |
| parent | 8221545c440b5f83f00b3e5a92bbc86bf268bad4 (diff) | |
| download | lwn-c86a918b1bdba78fb155184f8d88dfba1e63335d.tar.gz lwn-c86a918b1bdba78fb155184f8d88dfba1e63335d.zip | |
spi: don't unoptimize message in spi_async()
Calling spi_maybe_unoptimize_message() in spi_async() is wrong because
the message is likely to be in the queue and not transferred yet. This
can corrupt the message while it is being used by the controller driver.
spi_maybe_unoptimize_message() is already called in the correct place
in spi_finalize_current_message() to balance the call to
spi_maybe_optimize_message() in spi_async().
Fixes: 7b1d87af14d9 ("spi: add spi_optimize_message() APIs")
Signed-off-by: David Lechner <dlechner@baylibre.com>
Link: https://patch.msgid.link/20240708-spi-mux-fix-v1-1-6c8845193128@baylibre.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi')
| -rw-r--r-- | drivers/spi/spi.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index fc13fa192189..679ee414cbea 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -4432,8 +4432,6 @@ int spi_async(struct spi_device *spi, struct spi_message *message) spin_unlock_irqrestore(&ctlr->bus_lock_spinlock, flags); - spi_maybe_unoptimize_message(message); - return ret; } EXPORT_SYMBOL_GPL(spi_async); |