diff options
| author | Lukasz Majewski <lukma@denx.de> | 2019-09-25 11:11:42 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2019-09-25 09:46:23 -0700 |
| commit | 9f918a728cf86b2757b6a7025e1f46824bfe3155 (patch) | |
| tree | 420f216c4c76c332ae5ec63913891d7fc47809ee /drivers/spi/spidev.c | |
| parent | 6fe7ab3837bdbc4830addac9898a5e4bc0783dcc (diff) | |
| download | lwn-9f918a728cf86b2757b6a7025e1f46824bfe3155.tar.gz lwn-9f918a728cf86b2757b6a7025e1f46824bfe3155.zip | |
spi: Add call to spi_slave_abort() function when spidev driver is released
This change is necessary for spidev devices (e.g. /dev/spidev3.0) working
in the slave mode (like NXP's dspi driver for Vybrid SoC).
When SPI HW works in this mode - the master is responsible for providing
CS and CLK signals. However, when some fault happens - like for example
distortion on SPI lines - the SPI Linux driver needs a chance to recover
from this abnormal situation and prepare itself for next (correct)
transmission.
This change doesn't pose any threat on drivers working in master mode as
spi_slave_abort() function checks if SPI slave mode is supported.
Signed-off-by: Lukasz Majewski <lukma@denx.de>
Link: https://lore.kernel.org/r/20190924110547.14770-2-lukma@denx.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Reported-by: kbuild test robot <lkp@intel.com>
Link: https://lore.kernel.org/r/20190925091143.15468-2-lukma@denx.de
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spidev.c')
| -rw-r--r-- | drivers/spi/spidev.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/spi/spidev.c b/drivers/spi/spidev.c index 255786f2e844..3ea9d8a3e6e8 100644 --- a/drivers/spi/spidev.c +++ b/drivers/spi/spidev.c @@ -627,6 +627,9 @@ static int spidev_release(struct inode *inode, struct file *filp) if (dofree) kfree(spidev); } +#ifdef CONFIG_SPI_SLAVE + spi_slave_abort(spidev->spi); +#endif mutex_unlock(&device_list_lock); return 0; |