diff options
| author | Geert Uytterhoeven <geert+renesas@glider.be> | 2018-09-05 10:51:57 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2018-09-05 12:38:27 +0100 |
| commit | 7c5d8a249acadc3e9d5af643c0fe24b608a98269 (patch) | |
| tree | f5b8e95d463efa0ad7a704f85397bd8941203278 /drivers/spi/spi-pl022.c | |
| parent | 35386dfd13b746daf36a393bdf066dbe9b9b7aed (diff) | |
| download | lwn-7c5d8a249acadc3e9d5af643c0fe24b608a98269.tar.gz lwn-7c5d8a249acadc3e9d5af643c0fe24b608a98269.zip | |
spi: Do not print a message if spi_controller_{suspend,resume}() fails
spi_controller_{suspend,resume}() already prints an error message on
failure, so there is no need to repeat this in individual drivers.
Note: spi_master_{suspend,resume}() is an alias for
spi_controller_{suspend,resume}().
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Reviewed-by: Daniel Mack <daniel@zonque.org>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-pl022.c')
| -rw-r--r-- | drivers/spi/spi-pl022.c | 8 |
1 files changed, 2 insertions, 6 deletions
diff --git a/drivers/spi/spi-pl022.c b/drivers/spi/spi-pl022.c index 1af8c96b940e..5f5f197b153c 100644 --- a/drivers/spi/spi-pl022.c +++ b/drivers/spi/spi-pl022.c @@ -2325,10 +2325,8 @@ static int pl022_suspend(struct device *dev) int ret; ret = spi_master_suspend(pl022->master); - if (ret) { - dev_warn(dev, "cannot suspend master\n"); + if (ret) return ret; - } ret = pm_runtime_force_suspend(dev); if (ret) { @@ -2353,9 +2351,7 @@ static int pl022_resume(struct device *dev) /* Start the queue running */ ret = spi_master_resume(pl022->master); - if (ret) - dev_err(dev, "problem starting queue (%d)\n", ret); - else + if (!ret) dev_dbg(dev, "resumed\n"); return ret; |