diff options
| author | Zhang Qilong <zhangqilong3@huawei.com> | 2020-11-06 09:24:21 +0800 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2020-11-18 18:00:26 +0000 |
| commit | 03fc41afaa6549baa2dab7a84e1afaf5cadb5b18 (patch) | |
| tree | 5902e3a4240f33e06ae5fe3c6b4853dda0423bf1 /drivers/spi/spi-mxs.c | |
| parent | 6e3dbfcb3c8a1ef8cc73a8637f778673f5c6e91c (diff) | |
| download | lwn-03fc41afaa6549baa2dab7a84e1afaf5cadb5b18.tar.gz lwn-03fc41afaa6549baa2dab7a84e1afaf5cadb5b18.zip | |
spi: mxs: fix reference leak in mxs_spi_probe
pm_runtime_get_sync will increment pm usage counter even it
failed. Forgetting to pm_runtime_put_noidle will result in
reference leak in mxs_spi_probe, so we should fix it.
Fixes: b7969caf41a1d ("spi: mxs: implement runtime pm")
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
Link: https://lore.kernel.org/r/20201106012421.95420-1-zhangqilong3@huawei.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Diffstat (limited to 'drivers/spi/spi-mxs.c')
| -rw-r--r-- | drivers/spi/spi-mxs.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c index 918918a9e049..435309b09227 100644 --- a/drivers/spi/spi-mxs.c +++ b/drivers/spi/spi-mxs.c @@ -607,6 +607,7 @@ static int mxs_spi_probe(struct platform_device *pdev) ret = pm_runtime_get_sync(ssp->dev); if (ret < 0) { + pm_runtime_put_noidle(ssp->dev); dev_err(ssp->dev, "runtime_get_sync failed\n"); goto out_pm_runtime_disable; } |