diff options
| author | Trent Piepho <tpiepho@gmail.com> | 2013-10-01 13:15:18 -0700 |
|---|---|---|
| committer | Mark Brown <broonie@linaro.org> | 2013-10-18 01:00:31 +0100 |
| commit | 1a33073fcf11e70447b704c0228e28099e6ab39d (patch) | |
| tree | 51941bf0188370a8e67648b1b4db45f257913353 /drivers/spi/spi-mxs.c | |
| parent | 210f65fedf1d26d0a1d604fa82425018f7ad6090 (diff) | |
| download | lwn-1a33073fcf11e70447b704c0228e28099e6ab39d.tar.gz lwn-1a33073fcf11e70447b704c0228e28099e6ab39d.zip | |
spi: spi-mxs: Remove bogus setting of ssp clk rate field
The ssp struct has a clock rate field, to provide the actual value, in Hz,
of the SSP output clock (the rate of SSP_SCK) after mxs_ssp_set_clk_rate()
is called. It is set by mxs_ssp_set_clk_rate(), for SSP using drivers (like
SPI and MMC) to *read* if they want to know the actual clock rate. The SPI
driver isn't supposed to *write* to it.
For some reason the spi-mxs driver decides to write to this field on init,
and sets it to the value of the SSP input clock (clk_sspN, from the MXS
clocking block) in kHz. It shouldn't be setting the value, and certainly
shouldn't be setting it with the wrong clock in the wrong units.
Signed-off-by: Trent Piepho <tpiepho@gmail.com>
Cc: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <fabio.estevam@freescale.com>
Cc: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>
Diffstat (limited to 'drivers/spi/spi-mxs.c')
| -rw-r--r-- | drivers/spi/spi-mxs.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/drivers/spi/spi-mxs.c b/drivers/spi/spi-mxs.c index de7387ef25b8..8cb5d8b6f042 100644 --- a/drivers/spi/spi-mxs.c +++ b/drivers/spi/spi-mxs.c @@ -536,7 +536,6 @@ static int mxs_spi_probe(struct platform_device *pdev) goto out_dma_release; clk_set_rate(ssp->clk, clk_freq); - ssp->clk_rate = clk_get_rate(ssp->clk) / 1000; ret = stmp_reset_block(ssp->base); if (ret) |